Re: typemode for variable types

From: Greg Stark <stark(at)mit(dot)edu>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org, Mohsen SM <mohsensoodkhah(at)gmail(dot)com>
Subject: Re: typemode for variable types
Date: 2014-02-25 12:59:50
Message-ID: CAM-w4HMcShT0-mr06vzqTLNUJ76=h0mpdJBaCSEJ7sPfb0hAHg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Also keep in mind that the system doesn't always retain the typmod. So the
datum should be possible to interpret without the typmod. Incidental
effects such as length limits or precision displayed are ok but the meaning
shouldn't be changed.

--
greg
On 24 Feb 2014 20:34, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > Bruce Momjian escribió:
> >> Well, typmods are type-specific, so there is no official way to
> >> calculate it. I would look at how an existing type uses typmod and copy
> >> that.
>
> > Our system is pretty neat. See a complex example here:
> >
> https://github.com/postgis/postgis/blob/svn-trunk/postgis/gserialized_typmod.c
>
> One other point is that if you do consult the varchar functions as
> an example, be aware that there's an offset of 4 in their definition
> of the typmod (eg, for varchar(3) the stored typmod is 7). This is
> entirely for legacy reasons so there's no good reason to duplicate it
> in a new custom-made type. Except for the rule that negative values
> mean "unspecified typmod" (which you have to support), you can
> define the contents of the typmod value however you want.
>
> regards, tom lane
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Vázquez 2014-02-25 13:00:20 Re: Same double precision operations, different results
Previous Message Florian Pflug 2014-02-25 12:33:01 Re: [PATCH] Negative Transition Aggregate Functions (WIP)