| From: | Greg Stark <stark(at)mit(dot)edu> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: epoll_wait returning EFAULT on Linux 3.2.78 |
| Date: | 2016-06-02 17:15:54 |
| Message-ID: | CAM-w4HMCvwjHkGSi8XOVXzu3D3bXGLGC6yr0q=E7N_U0E6WA9g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 2, 2016 at 6:04 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Greg, are you writing & testing a patch? Or should I write something for
> you to test?
I'm running the regression tests now. They look like they're passing.
I just threw maxalign everywhere but I was going to comment that we
might need to put a double in for the subsequent struct elements to
end up aligned as well. But I guess that's not true due to the u64
element. I'm not sure I've completely grokked all the bits and pieces
here so I may have added a few too many maxaligns. I put them on all
the size and offset calculations before the multiplications.
--
greg
| Attachment | Content-Type | Size |
|---|---|---|
| maxalign-latch.patch | text/x-patch | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-06-02 17:24:38 | Re: epoll_wait returning EFAULT on Linux 3.2.78 |
| Previous Message | Andres Freund | 2016-06-02 17:04:34 | Re: epoll_wait returning EFAULT on Linux 3.2.78 |