| From: | Greg Stark <stark(at)mit(dot)edu> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_get_viewdefs() indentation considered harmful |
| Date: | 2014-04-30 19:23:59 |
| Message-ID: | CAM-w4HM++8QW_dm3ovfC+CuibpbNHZYrgwJMqkgDUNOFNC-EOA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 30, 2014 at 6:47 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I pushed a patch that does it that way, and also patches for the other
> items discussed in this thread.
Great! thanks a lot. This makes a really solid noticeable difference
even in relatively simple cases and I know of users for whom this will
make a big difference.
That indentation code looks like a lot of work to maintain that I
hadn't really been aware of before. I wonder if there's some way to
combine it with the actual grammar so the input and output can be
edited in the same place.
--
greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2014-04-30 19:29:34 | Re: GSoC on WAL-logging hash indexes |
| Previous Message | Greg Stark | 2014-04-30 19:16:53 | Re: GSoC on WAL-logging hash indexes |