| From: | Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Luc Vlaming <luc(at)swarm64(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com> |
| Subject: | Re: should INSERT SELECT use a BulkInsertState? |
| Date: | 2021-03-18 13:37:41 |
| Message-ID: | CALtqXTevpr93xMJYo143ji9JhUhcbQ-oVGwLKGjnJMXMS_juSA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 8, 2021 at 2:18 PM houzj(dot)fnst(at)fujitsu(dot)com <
houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> > > > I am very interested in this patch, and I plan to do some
> > > > experiments with the
> > > patch.
> > > > Can you please rebase the patch because it seems can not applied to
> > > > the
> > > master now.
> > >
> > > Thanks for your interest.
> > >
> > > I was sitting on a rebased version since the bulk FDW patch will cause
> > > conflicts, and since this should maybe be built on top of the table-am
> patch
> > (2871).
> > > Have fun :)
> > Hi,
> >
> > When I testing with the patch, I found I can not use "\d tablename".
> > It reports the following error, it this related to the patch?
>
> Sorry, solved by re-initdb.
>
> Best regards,
> houzj
>
>
> One of the patch
(v10-0001-INSERT-SELECT-to-use-BulkInsertState-and-multi_i.patch) from the
patchset does not apply.
http://cfbot.cputube.org/patch_32_2553.log
1 out of 13 hunks FAILED -- saving rejects to file
src/backend/commands/copyfrom.c.rej
It is a minor change, therefore I fixed that to make cfbot happy. Please
take a look if that works for you.
--
Ibrar Ahmed
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-INSERT-SELECT-to-use-BulkInsertState-and-multi_i.patch | application/octet-stream | 46.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2021-03-18 13:38:09 | Re: pg_stat_statements and "IN" conditions |
| Previous Message | Álvaro Hernández | 2021-03-18 13:37:01 | Re: CDC feature request |