Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work

From: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work
Date: 2022-09-03 05:47:32
Message-ID: CALtqXTek3sdCBkE=i6Dkw=3PGWhrvCybqro6g8qJGLR64O4Zig@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Sep 3, 2022 at 3:09 AM Nathan Bossart <nathandbossart(at)gmail(dot)com>
wrote:

> On Fri, Sep 02, 2022 at 05:09:14PM +0900, Michael Paquier wrote:
> > I had a few hours and I've spent them looking at what you had here in
> > details, and there were a few things I have tweaked before applying
> > the patch.
>
> Thanks!
>
> --
> Nathan Bossart
> Amazon Web Services: https://aws.amazon.com
>
>
> Hi,

Your patch require a rebase. Please provide the latest rebase patch.

=== applying patch
./v17-0001-Make-more-use-of-get_dirent_type-in-place-of-sta.patch
patching file src/backend/access/heap/rewriteheap.c
Hunk #1 FAILED at 113.
Hunk #2 FAILED at 1213.
Hunk #3 FAILED at 1221.
3 out of 3 hunks FAILED -- saving rejects to file
src/backend/access/heap/rewriteheap.c.rej

--
Ibrar Ahmed

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2022-09-03 05:50:24 Re: warning: comparison of integer expressions of different signedness related to simd.h
Previous Message Ibrar Ahmed 2022-09-03 05:36:37 Re: pgbench: using prepared BEGIN statement in a pipeline could cause an error