| From: | Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> |
|---|---|
| To: | Paul Guo <guopa(at)vmware(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, "Asim Praveen (Pivotal)" <apraveen(at)pivotal(dot)io>, "Lei Wang (Pivotal)" <leiwang(at)pivotal(dot)io>, "thomas(dot)munro(at)gmail(dot)com" <thomas(dot)munro(at)gmail(dot)com>, "horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp" <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: standby recovery fails (tablespace related) (tentative patch and discussion) |
| Date: | 2021-07-09 19:37:57 |
| Message-ID: | CALtqXTejpfCX7UF0D-OFUW6a5-ep3iqD2fj5xgy18yDqk1Hw4w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 30, 2021 at 12:12 PM Paul Guo <guopa(at)vmware(dot)com> wrote:
> On 2021/3/27, 10:23 PM, "Alvaro Herrera" <alvherre(at)2ndquadrant(dot)com> wrote:
>
> > Hmm, can you post a rebased set, where the points under discussion
> > are marked in XXX comments explaining what the issue is? This thread
> is
> > long and old ago that it's pretty hard to navigate the whole thing in
> > order to find out exactly what is being questioned.
>
> OK. Attached are the rebased version that includes the change I discussed
> in my previous reply. Also added POD documentation change for
> RecursiveCopy,
> and modified the patch to use the backup_options introduced in
> 081876d75ea15c3bd2ee5ba64a794fd8ea46d794 for tablespace mapping.
>
> > I think 0004 can be pushed without further ado, since it's a clear and
> > simple fix. 0001 needs a comment about the new parameter in
> > RecursiveCopy's POD documentation.
>
> Yeah, 0004 is no any risky. One concern seemed to be the compatibility of
> some
> WAL dump/analysis tools(?). I have no idea about this. But if we do not
> backport
> 0004 we do not seem to need to worry about this.
>
> > As I understand, this is a backpatchable bug-fix.
>
> Yes.
>
> Thanks.
>
> Patch does not apply successfully,
http://cfbot.cputube.org/patch_33_2161.log
Can you please rebase the patch.
--
Ibrar Ahmed
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2021-07-09 20:00:01 | BUG #17098: Assert failed on composing an error message when adding a type to an extension being dropped |
| Previous Message | Robert Haas | 2021-07-09 19:29:51 | Re: enable_resultcache confusion |