Re: [patch] bit XOR aggregate functions

From: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
To: bashtanov(at)imap(dot)cc, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Subject: Re: [patch] bit XOR aggregate functions
Date: 2021-03-04 17:14:26
Message-ID: CALtqXTdS-k_oNq1ZwHZ4NS=hX+q9yndDYApUTU8RbzZq-n952w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 3, 2021 at 7:30 PM Peter Eisentraut <
peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:

> On 10.02.21 06:42, Kyotaro Horiguchi wrote:
> > We already had CREATE AGGREATE at the time, so BIT_XOR can be thought
> > as it falls into the same category with BIT_AND and BIT_OR, that is,
> > we may have BIT_XOR as an intrinsic aggregation?
>
> I think the use of BIT_XOR is quite separate from BIT_AND and BIT_OR.
> The latter give you an "all" or "any" result of the bits set. BIT_XOR
> will return 1 or true if an odd number of inputs are 1 or true, which
> isn't useful by itself. But it can be used as a checksum, so it seems
> pretty reasonable to me to add it. Perhaps the use case could be
> pointed out in the documentation.
>
>
>
>
Hi Alex,

The patch is failing just because of a comment, which is already changed by
another patch

-/* Define to build with OpenSSL support. (--with-ssl=openssl) */

+/* Define to 1 if you have OpenSSL support. */

Do you mind sending an updated patch?

http://cfbot.cputube.org/patch_32_2980.log.

I am changing the status to "Waiting for Author"

In my opinion that change no more requires so I removed that and attached
the patch.

--
Ibrar Ahmed

Attachment Content-Type Size
bit-xor-agg-v002.diff application/octet-stream 7.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2021-03-04 17:27:54 Re: pg_amcheck contrib application
Previous Message Alvaro Herrera 2021-03-04 17:05:36 Re: [HACKERS] PATCH: Batch/pipelining support for libpq