| From: | Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade: Error out on too many command-line arguments |
| Date: | 2019-08-25 18:50:44 |
| Message-ID: | CALtqXTcCZ=GXxehmQoTNXXXi5=1r5cV8=yt1P8_p1Mg_v+m+qQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Aug 25, 2019 at 8:39 PM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> On Sun, Aug 25, 2019 at 4:30 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> > Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> > > I propose the attached patch to make pg_upgrade error out on too many
> > > command-line arguments. This makes it match the behavior of other
> > > PostgreSQL programs.
> >
> > +1 ... are we missing this anywhere else?
>
> I did some searching, and oid2name.c is also missing this.
>
> Yes, "oid2name" missing that check too.
--
Ibrar Ahmed
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-oid2name-Error-out-on-too-many-command-line-argume.patch | application/octet-stream | 505 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Quentin Rameau | 2019-08-25 19:00:09 | Re: [PATCH] Fix missing argument handling in psql getopt |
| Previous Message | Vik Fearing | 2019-08-25 18:49:11 | Outputting Standard SQL |