| From: | Ted Yu <yuzhihong(at)gmail(dot)com> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: MERGE ... WHEN NOT MATCHED BY SOURCE |
| Date: | 2023-01-21 14:17:36 |
| Message-ID: | CALte62z9j3Sa-QksqsZ2zQwwxijWgx2Nu3j_+81GE11pcu6MwA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 21, 2023 at 3:05 AM Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
wrote:
> On Tue, 10 Jan 2023 at 14:43, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
> wrote:
> >
> > Rebased version attached.
> >
>
> Rebased version, following 8eba3e3f02 and 5d29d525ff.
>
> Regards,
> Dean
>
Hi,
In transform_MERGE_to_join :
+ if (action->matchKind ==
MERGE_WHEN_NOT_MATCHED_BY_SOURCE)
+ tgt_only_tuples = true;
+ if (action->matchKind ==
MERGE_WHEN_NOT_MATCHED_BY_TARGET)
There should be an `else` in front of the second `if`.
When tgt_only_tuples and src_only_tuples are both true, we can come out of
the loop.
Cheers
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2023-01-21 15:00:31 | Re: run pgindent on a regular basis / scripted manner |
| Previous Message | Karl O. Pinc | 2023-01-21 14:11:43 | Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences |