checking rd_rules in RelationBuildDesc

From: Ted Yu <yuzhihong(at)gmail(dot)com>
To: dean(dot)a(dot)rasheed(at)gmail(dot)com, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: checking rd_rules in RelationBuildDesc
Date: 2022-11-25 15:56:13
Message-ID: CALte62wkWEaUkC-Nbh8wkrQ3=VgDVpV3fTWbFR=c22VJmvWysg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
(In light of commit 7b2ccc5e03bf16d1e1bbabca25298108c839ec52)

In RelationBuildDesc(), we have:

if (relation->rd_rel->relhasrules)
RelationBuildRuleLock(relation);

I wonder if we should check relation->rd_rules after the call
to RelationBuildRuleLock().

Your comment is appreciated.

Attachment Content-Type Size
build-desc-check-rules.patch application/octet-stream 482 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sergey Shinderuk 2022-11-25 16:01:09 Re: Bug in row_number() optimization
Previous Message Dimos Stamatakis 2022-11-25 15:46:08 Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency