| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Move backup-related code to xlogbackup.c/.h |
| Date: | 2022-10-19 10:56:03 |
| Message-ID: | CALj2ACXrgJSzBAOWb48h9KVAOStaueZCy84040=fZOU3rvBFRw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 19, 2022 at 4:23 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2022-Oct-19, Bharath Rupireddy wrote:
>
> > When the standby is in recovery, calls to XLogInsertRecord() or
> > AdvanceXLInsertBuffer()) where forcePageWrites is being used, won't
> > happen, no?
> >
> > * Note that forcePageWrites has no effect during an online backup from
> > - * the standby.
> > + * the standby. XXX what does this mean??
>
> Well, yes, but when looking at this comment I wonder why do I *care*
> about this point. I left this comment has you changed it, but I wonder
> if we shouldn't just remove it.
Well,retaining that comment does no harm IMO.
> > I removed the 2 more instances of forcePageWrites left-out and tweaked
> > the comments a little and attached 0002.
>
> Thanks for looking. Pushed now.
Thanks. I will rebase and post the other patches soon.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-10-19 11:17:42 | Re: TRAP: FailedAssertion("prev_first_lsn < cur_txn->first_lsn", File: "reorderbuffer.c", Line: 927, PID: 568639) |
| Previous Message | Alvaro Herrera | 2022-10-19 10:53:00 | Re: Move backup-related code to xlogbackup.c/.h |