From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
---|---|
To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work |
Date: | 2022-08-17 07:09:26 |
Message-ID: | CALj2ACXZPMYXrPZ+CUE0_5DKDnxyqDGRftSgPPx--PWhWB3RtQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Aug 17, 2022 at 2:02 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Wed, Aug 10, 2022 at 03:28:25PM +0530, Bharath Rupireddy wrote:
> > snprintf(path, sizeof(path), "pg_logical/mappings/%s", mapping_de->d_name);
> > - if (lstat(path, &statbuf) == 0 && !S_ISREG(statbuf.st_mode))
> > + if (get_dirent_type(path, mapping_de, false, LOG) != PGFILETYPE_REG)
> > continue;
>
> Previously, failure to lstat() wouldn't lead to skipping the entry. With
> this patch, a failure to determine the file type will cause the entry to be
> skipped. This might be okay in some places (e.g., CheckPointSnapBuild())
> but not in others. For example, in CheckPointLogicalRewriteHeap(), this
> could cause us to skip fsync-ing a file due to a get_dirent_type() failure,
> which seems bad.
Hm. I corrected it in the v16 patch, please review.
--
Bharath Rupireddy
RDS Open Source Databases: https://aws.amazon.com/rds/postgresql/
Attachment | Content-Type | Size |
---|---|---|
v16-0001-Make-more-use-of-get_dirent_type-in-place-of-sta.patch | application/octet-stream | 17.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2022-08-17 07:33:24 | Re: Propose a new function - list_is_empty |
Previous Message | Peter Smith | 2022-08-17 07:03:50 | Re: Handle infinite recursion in logical replication setup |