| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Propose a new function - list_is_empty |
| Date: | 2022-08-17 07:33:24 |
| Message-ID: | 958D94C6-D23B-4434-818A-F26141D31F79@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 17 Aug 2022, at 03:09, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Wed, Aug 17, 2022 at 6:34 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>> On 16 Aug 2022, at 16:03, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>>> I agree though that while simplifying list_length() calls, I'd lean to using
>>> explicit comparisons to NIL.
>>
>>
>> Agreed, I prefer that too.
>>
>
> Thanks for the feedback.
>
> PSA patch v3 which now uses explicit comparisons to NIL everywhere,
> and also addresses the other review comments.
From reading, this version of the patch looks good to me.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2022-08-17 07:51:17 | Re: SYSTEM_USER reserved word implementation |
| Previous Message | Bharath Rupireddy | 2022-08-17 07:09:26 | Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work |