| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Typo in misc_sanity.sql? |
| Date: | 2022-07-25 08:02:35 |
| Message-ID: | CALj2ACXLbBy7LO06eq-z=zrYNRbNDk1KAOsYn81o_QEHYfu4nw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 25, 2022 at 1:24 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
>
>
> Hi, hackers
>
> I found the misc_sanity has a SQL to check system catalogs that
> do not have primary keys, however, in current exceptions it says
> pg_depend, pg_shdepend don't have a unique key.
>
> Should we fix it?
Indeed. There's a clear difference between primary key and unique key.
The patch LGTM.
Regards,
Bharath Rupireddy.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2022-07-25 08:51:38 | Re: Is it correct to say, "invalid data in file \"%s\"", BACKUP_LABEL_FILE in do_pg_backup_stop? |
| Previous Message | Peter Smith | 2022-07-25 07:57:09 | Re: Column Filtering in Logical Replication |