| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Euler Taveira <euler(at)eulerto(dot)com>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c |
| Date: | 2021-09-13 03:21:18 |
| Message-ID: | CALj2ACX8rqYL7FyXzSZTNRcxU29LygxCf74vDf0XfDHtkNu68A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 13, 2021 at 8:07 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Sun, Sep 12, 2021 at 10:14:36PM -0300, Euler Taveira wrote:
> > On Sun, Sep 12, 2021, at 8:02 PM, Bossart, Nathan wrote:
> >> nitpick: It looks like there's an extra set of parentheses around
> >> errmsg().
> >
> > Indeed. Even the requirement for extra parenthesis around auxiliary function
> > calls was removed in v12 (e3a87b4991cc2d00b7a3082abb54c5f12baedfd1).
>
> Yes. The patch makes sense. I am not seeing any other places that
> could be grouped, so that looks fine as-is.
Thanks all for taking a look at the patch. Here's the CF entry -
https://commitfest.postgresql.org/35/3319/
Regards,
Bharath Rupireddy.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2021-09-13 03:54:09 | document the need to analyze partitioned tables |
| Previous Message | Bharath Rupireddy | 2021-09-13 03:17:16 | Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c |