| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Amul Sul <sulamul(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options |
| Date: | 2021-06-18 13:05:28 |
| Message-ID: | CALj2ACWzCSzEvZDnU2peyA5m6Sx8A7a2tCLMwA_18o+x36VckQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 10, 2021 at 6:36 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Thu, Jun 10, 2021 at 9:17 AM Bharath Rupireddy
> <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> > > I don't know the answer; my guess is that all this has become obsolete
> > > and the whole Assert and the dodgy comment can just be deleted.
> >
> > Hm. I get it. Unfortunately the commit b1ff33f is missing information
> > on what the coverity tool was complaining of and it has no related
> > discussion at all.
> >
> > I agree to remove that assertion entirely. I will post a new patch set soon.
>
> PSA v5 patch set.
PSA v6 patch set rebased onto the latest master.
With Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Refactor-parse_subscription_options.patch | application/octet-stream | 26.6 KB |
| v6-0002-Remove-similar-ereport-calls-in-parse_subscriptio.patch | application/octet-stream | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Boris Kolpackov | 2021-06-18 13:52:41 | Re: Add version macro to libpq-fe.h |
| Previous Message | Fabien COELHO | 2021-06-18 12:54:27 | Re: pgbench bug candidate: negative "initial connection time" |