Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit

On Tue, Jan 26, 2021 at 12:54 PM Fujii Masao
<masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> On 2021/01/26 16:05, Tom Lane wrote:
> > Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
> >> Thanks for the review! I fixed them and pushed the patch!
> >
> > Buildfarm is very not happy ...
>
> Yes.... I'm investigating that.
>
> -- Return false as connections are still in use, warnings are issued.
> SELECT postgres_fdw_disconnect_all();
> -WARNING: cannot close dropped server connection because it is still in use
> -WARNING: cannot close connection for server "loopback" because it is still in use
> WARNING: cannot close connection for server "loopback2" because it is still in use
> +WARNING: cannot close connection for server "loopback" because it is still in use
> +WARNING: cannot close dropped server connection because it is still in use
>
> The cause of the regression test failure is that the order of warning messages
> is not stable. So I'm thinking to set client_min_messages to ERROR temporarily
> when doing the above test.

Looks like we do suppress warnings/notices by setting
client_min_messages to ERROR/WARNING. For instance, "suppress warning
that depends on wal_level" and "Suppress NOTICE messages when
users/groups don't exist".

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com