Re: Log message for GSS connection is missing once connection authorization is successful.

On Thu, Nov 5, 2020 at 7:55 AM Euler Taveira <euler(dot)taveira(at)2ndquadrant(dot)com>
wrote:
>
> No. Don't worry with translations during the development. Make sure to
follow
> the instructions provided here [1]. Translations are coordinated in a
different
> mailing list: pgsql-translators [2]. There is a different repository [3]
for
> handling PO files and the updated files are merged by Peter Eisentraut
just
> before each minor/major release. We usually start to update translations
after
> feature freeze.
>

Thanks.

On Tue, Nov 3, 2020 at 12:49 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Thanks for the explanation, I have attached a v5 patch with the
> changes where the translation should not have any problem.
>

I have taken a further look at the V5 patch:

1. We wait 10sec until the syslogger process logs the expected message,
what happens if someone intentionally made the syslogger process to wait
for a longer duration? Will the new tests fail?
# might need to retry if logging collector process is slow...
my $max_attempts = 10 * 10;
my $first_logfile;
for (my $attempts = 0; $attempts < $max_attempts; $attempts++)
{
$first_logfile = slurp_file($node->data_dir . '/' . $lfname);
last if $first_logfile =~ m/$expect_log_msg /;
usleep(100_000);
}

2. I intentionally altered(for testing purpose only) the expected log
message input given to test_access(), expecting the tests to fail, but the
test succeeded. Am I missing something here? Is it that the syslogger
process not logging the message at all or within the 10sec waiting? Do we
need to increase the wait duration? Do we need to do something to fail the
test when we don't see the expected log message in test_access()?

"*cXNnnection* authorized: user=......
"*connecTEion *authorized: user=....
"connection *auTThorized*:.....

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com