From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Add BF member koel-like indentation checks to SanityCheck CI |
Date: | 2023-10-30 07:20:44 |
Message-ID: | CALj2ACWMupLTuD+bWfr2oBsNDpFJiuFaCK17S3Ty0YJbywdSfA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
How about adding code indent checks (like what BF member koel has) to
the SanityCheck CI task? This helps catch indentation problems way
before things are committed so that developers can find them out in
their respective CI runs and lets developers learn the postgres code
indentation stuff. It also saves committers time - git log | grep
'koel' | wc -l gives me 11 commits and git log | grep 'indentation' |
wc -l gives me 97. Most, if not all of these commits went into fixing
code indentation problems that could have been reported a bit early
and fixed by developers/patch authors themselves.
Thoughts?
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Borisov | 2023-10-30 07:29:04 | Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. |
Previous Message | Michael Paquier | 2023-10-30 07:08:50 | Re: Requiring recovery.signal or standby.signal when recovering with a backup_label |