Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?
Date: 2022-02-11 03:40:07
Message-ID: CALj2ACWBff=_Akom=wojtFRtbfOPF1EFs-2TAfA_0DKrg9=mLQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 11, 2022 at 12:29 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>
> On Thu, Feb 10, 2022 at 10:21:08PM +0530, Bharath Rupireddy wrote:
> > Thanks for the comments. Above looks good to me, changed that way, PSA v2.
>
> I spy a typo: subcription

Thanks. Corrected in v3 attached.

The CF entry https://commitfest.postgresql.org/36/3354/ was closed
with "Returned with Feedback". I'm not sure why. If the patch is still
of interest, I will add a new one for tracking.

Regards,
Bharath Rupireddy.

Attachment Content-Type Size
v3-0001-add-vcregress-taptest-and-mention-about-Windows-o.patch application/octet-stream 3.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2022-02-11 03:46:39 Re: List of all* PostgreSQL EXTENSIONs in the world
Previous Message Julien Rouhaud 2022-02-11 03:15:49 Re: List of all* PostgreSQL EXTENSIONs in the world