| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Kazutaka Onishi <onishi(at)heterodb(dot)com> |
| Cc: | Kohei KaiGai <kaigai(at)heterodb(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Subject: | Re: TRUNCATE on foreign table |
| Date: | 2021-04-07 01:15:39 |
| Message-ID: | CALj2ACW9zKrRXt8psoBn3W4xo44qc9dO6TRA1-3Gh6FYEpAuNw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 6, 2021 at 10:15 PM Kazutaka Onishi <onishi(at)heterodb(dot)com> wrote:
> I've checked v15 patch with "make check-world" and confirmed this passed.
Thanks for the patch. One minor thing - I think "mixtured" is not the
correct word in "+-- partition table mixtured by table and foreign
table". How about something like "+-- partitioned table with both
local and foreign table as partitions"?
The v15 patch basically looks good to me. I have no more comments.
CF entry https://commitfest.postgresql.org/32/2972/ still says it's
"waiting on author", do you want to change it to "needs review" if you
have no open points left so that others can take a look at it?
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-04-07 01:20:31 | Re: Proposal: Save user's original authenticated identity for logging |
| Previous Message | Bharath Rupireddy | 2021-04-07 01:01:19 | Re: Can we remove extra memset in BloomInitPage, GinInitPage and SpGistInitPage when we have it in PageInit? |