Re: Remove extra Logging_collector check before calling SysLogger_Start()

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove extra Logging_collector check before calling SysLogger_Start()
Date: 2021-12-03 08:32:27
Message-ID: CALj2ACW2pVV8zx_eC_f3WHwrbc1WZ0vV4vDrs1fYZWRAT9TaxQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 3, 2021 at 1:43 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 3 Dec 2021, at 08:58, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> > It seems like there's an extra Logging_collector check before calling
> > SysLogger_Start(). Note that the SysLogger_Start() has a check to
> > return 0 if Logging_collector is off. This change is consistent with
> > the other usage of SysLogger_Start().
> >
> > /* If we have lost the log collector, try to start a new one */
> > - if (SysLoggerPID == 0 && Logging_collector)
> > + if (SysLoggerPID == 0)
> > SysLoggerPID = SysLogger_Start();
>
> I think the code reads clearer with the Logging_collector check left intact,
> and avoiding a function call in this codepath doesn't hurt.

In that case, can we remove if (!Logging_collector) within
SysLogger_Start() and have the check outside? This will save function
call costs in the other places too. The pgarch_start and
AutoVacuumingActive have checks outside PgArchStartupAllowed and
AutoVacuumingActive.

Regards,
Bharath Rupireddy.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-12-03 08:41:44 Re: issue in pgfdw_report_error()?
Previous Message Daniel Gustafsson 2021-12-03 08:13:14 Re: Remove extra Logging_collector check before calling SysLogger_Start()