| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Luc Vlaming <luc(at)swarm64(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel Inserts in CREATE TABLE AS |
| Date: | 2021-01-06 05:37:33 |
| Message-ID: | CALj2ACW1rTL=E78Joe4bDz9PwBTm47nKp8+iHe36-q1NisxWbw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 6, 2021 at 10:05 AM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
>
> The plan sounds good.
>
> Before the second command type is added, can you leave out the 'if (ins_cmd == PARALLEL_INSERT_CMD_CREATE_TABLE_AS)' and keep the pair of curlies ?
>
> You can add the if condition back when the second command type is added.
Thanks.
IMO, an empty pair of curlies is not a good idea. Having if (ins_cmd
== PARALLEL_INSERT_CMD_CREATE_TABLE_AS) doesn't harm anything.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-01-06 05:46:29 | Re: Parallel Inserts in CREATE TABLE AS |
| Previous Message | Andrew Dunstan | 2021-01-06 05:36:42 | Re: Cirrus CI (Windows help wanted) |