can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?
Date: 2021-10-05 17:25:30
Message-ID: CALj2ACW1g-6U9SC5a=Q7niE9CE_uZOaUEMoh19T2ND_h6qT-yw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

While working one of the internal features, I figured out that we
don't have subscription TAP tests option for "vcregress" tool for msvc
builds. Is there any specific reason that we didn't add "vcregress
subscriptioncheck" option similar to "vcregress recoverycheck"? It
looks like one can run with "vcregress taptest" option and PROVE_FLAGS
environment variable(I haven't tried it myself), but having
subscriptioncheck makes life easier.

Here's a small patch for that. Thoughts?

Regards,
Bharath Rupireddy.

Attachment Content-Type Size
v1-0001-add-subscriptioncheck-option-for-vcregress-for-ms.patch application/octet-stream 2.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2021-10-05 17:26:04 Re: storing an explicit nonce
Previous Message John Naylor 2021-10-05 17:24:58 Re: Polyphase merge is obsolete