Re: Add new error_action COPY ON_ERROR "log"

On Wed, Mar 13, 2024 at 5:16 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Mar 12, 2024 at 12:54:29PM +0530, Bharath Rupireddy wrote:
> > +1. But, do you want to add them now or later as a separate
> > patch/discussion altogether?
>
> The attached 0003 is what I had in mind:
> - Simplification of the LOG generated with quotes applied around the
> column name, don't see much need to add the relation name, either, for
> consistency and because the knowledge is known in the query.
> - A few more tests.
> - Some doc changes.

LGMT. So, I've merged those changes into 0001 and 0002.

> >> Wouldn't it be better to squash the patches together, by the way?
> >
> > I guess not. They are two different things IMV.
>
> Well, 0001 is sitting doing nothing because the COPY code does not
> make use of it internally.

Yes. That's why I left a note in the commit message that a future
commit will use it.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com