From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: issue in pgfdw_report_error()? |
Date: | 2021-11-19 12:57:49 |
Message-ID: | CALj2ACVt7HcH+qD7e-grw34eyfV6+WwZYE82--rwOik==1wWBg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Nov 19, 2021 at 1:48 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
> Hi,
>
> pgfdw_report_error() in postgres_fdw is implemented to report the message
> "could not obtain ..." if message_primary is NULL as follows.
> But, just before this ereport(), message_primary is set to
> pchomp(PQerrorMessage()) if it's NULL. So ISTM that message_primary is
> always not NULL in ereport() and the message "could not obtain ..." is
> never reported. Is this a bug?
>
> -------------------
> if (message_primary == NULL)
> message_primary = pchomp(PQerrorMessage(conn));
>
> ereport(elevel,
> (errcode(sqlstate),
> message_primary ? errmsg_internal("%s", message_primary) :
> errmsg("could not obtain message string for remote error"),
> -------------------
>
>
> If this is a bug, IMO the following change needs to be applied. Thought?
>
> -------------------
> ereport(elevel,
> (errcode(sqlstate),
> - message_primary ? errmsg_internal("%s", message_primary) :
> + (message_primary != NULL && message_primary[0] != '\0') ?
> + errmsg_internal("%s", message_primary) :
> errmsg("could not obtain message string for remote error"),
> -------------------
What if conn->errorMessage.data is NULL and PQerrorMessage returns it?
The message_primary can still be NULL right?
I see the other places where PQerrorMessage is used, they do check for
the NULL value in some places the others don't do.
in dblink.c:
msg = PQerrorMessage(conn);
if (msg == NULL || msg[0] == '\0')
PG_RETURN_TEXT_P(cstring_to_text("OK"));
Regards,
Bharath Rupireddy.
From | Date | Subject | |
---|---|---|---|
Next Message | Bharath Rupireddy | 2021-11-19 13:13:00 | Re: Shouldn't postgres_fdw report warning when it gives up getting result from foreign server? |
Previous Message | Andrey V. Lepikhov | 2021-11-19 11:10:59 | Re: Global snapshots |