Re: Use pgstat_progress_update_multi_param instead of single param update

On Sun, Feb 21, 2021 at 4:18 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Sun, Feb 21, 2021 at 11:30:21AM +0530, Bharath Rupireddy wrote:
> > Attached is a patch that replaces some subsequent multiple
> > update_param calls with a single update_multi_param.
>
> Looks mostly fine to me.
>
> - if (OidIsValid(indexOid))
> - pgstat_progress_update_param(PROGRESS_CLUSTER_COMMAND,
> - PROGRESS_CLUSTER_COMMAND_CLUSTER);
> - else
> - pgstat_progress_update_param(PROGRESS_CLUSTER_COMMAND,
> - PROGRESS_CLUSTER_COMMAND_VACUUM_FULL);
> + pgstat_progress_update_param(PROGRESS_CLUSTER_COMMAND,
> + OidIsValid(indexOid) ? PROGRESS_CLUSTER_COMMAND_CLUSTER :
> + PROGRESS_CLUSTER_COMMAND_VACUUM_FULL);
> What's the point of changing this one?

While we are at it, I wanted to use a single line statement instead of
if else, just like we do it in do_analyze_rel as below.

pgstat_progress_update_param(PROGRESS_ANALYZE_PHASE,
inh ?
PROGRESS_ANALYZE_PHASE_ACQUIRE_SAMPLE_ROWS_INH :
PROGRESS_ANALYZE_PHASE_ACQUIRE_SAMPLE_ROWS);

We can ignore it if it doesn't seem a good way.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com