| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Amul Sul <sulamul(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Cleanup - adjust the code crossing 80-column window limit |
| Date: | 2020-07-06 04:27:31 |
| Message-ID: | CALj2ACVjuPY+Guw0MJJgsbWm4zzhKpey9GLm0DFrbw8=6QbNAg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> Is there a test case covering this part of the code(I'm not sure if
> one exists in the regression test suite)?
> If no, can we add one?
>
I observed that the code areas this patch is trying to modify are
pretty much generic and are being called from many places.
The code basically handles exit callbacks on proc exits, on or before
shared memory exits which is very generic and common code.
I'm sure these parts are covered with the existing regression test suites.
Since I have previously run the regression tests, now finally, +1 for
the patch from my end.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2020-07-06 04:34:15 | Re: proposal: possibility to read dumped table's name from file |
| Previous Message | Michael Paquier | 2020-07-06 04:11:33 | Re: Cache lookup errors with functions manipulation object addresses |