| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts(). |
| Date: | 2021-10-27 05:15:38 |
| Message-ID: | CALj2ACVjm8rMzv5ij+Uif3E3iXxnFEH3_B5ptEoo9U3EFJPd=A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Oct 27, 2021 at 10:33 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Oct 27, 2021 at 10:27:18AM +0530, Bharath Rupireddy wrote:
> > +1 and the above statement looks good. Apart from that I have one more
> > suggestion that I earlier made: have the function produce the error
> > when no permissions were granted (just to ensure we have the error
> > message covered) including has_function_privilege() case.
>
> has_function_privilege() makes sure of the same thing, so I think that
> what Jeff has done for this part is just but fine. There is no need
> for more duplication in the tests.
Fair enough.
Regards,
Bharath Rupireddy.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-10-27 07:03:15 | pgsql: Add test for copy of shared dependencies from template database |
| Previous Message | Michael Paquier | 2021-10-27 05:03:22 | Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts(). |