| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds? |
| Date: | 2022-02-10 16:51:08 |
| Message-ID: | CALj2ACVhY9TU-TVVYpoZf9XCyWEspXip1=QV981Pg8XFx=xeRg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 13, 2021 at 5:09 AM Juan José Santamaría Flecha
<juanjo(dot)santamaria(at)gmail(dot)com> wrote:
>
>
> On Thu, Oct 21, 2021 at 7:21 AM Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>>
>>
>> Here's the documentation v1 patch that I've come up with. Please review it.
>>
> There's a typo:
> + To run an arbitrary TAP test set, run <command>vcregress taptest</command>
> + comamnd. For example, use the following command for running subcription TAP
> + tests:
> s/comamnd/command/
>
> But also the wording, I like better what vcregress prints as help, so something like:
> + You can use <command>vcregress taptest TEST_DIR</command> to run an
> + arbitrary TAP test set, where TEST_DIR is a required argument pointing to
> + the directory where the tests reside. For example, use the following
> + command for running the subcription TAP tests:
Thanks for the comments. Above looks good to me, changed that way, PSA v2.
Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-add-vcregress-taptest-and-mention-about-Windows-o.patch | application/octet-stream | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Swaha Miller | 2022-02-10 16:53:15 | Re: support for CREATE MODULE |
| Previous Message | Konstantin Knizhnik | 2022-02-10 16:46:43 | Race condition in TransactionIdIsInProgress |