Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included
Date: 2022-01-28 14:10:02
Message-ID: CALj2ACVe-W+WM5P44N7eG9C2_FmaeM8Dq5aCnD3fHt0Ba=WR6w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

It seems like there are some instances where xloginsert.h is included
right after xlog.h but xlog.h has already included xloginsert.h.
Unless I'm missing something badly, we can safely remove including
xloginsert.h after xlog.h. Attempting to post a patch to remove the
extra xloginsert.h includes.

Thoughts?

Regards,
Bharath Rupireddy.

Attachment Content-Type Size
v1-0001-remove-extra-includes-of-xloginsert.h-when-xlog.h.patch application/octet-stream 5.3 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2022-01-28 14:18:28 Re: [PATCH] Disable bgworkers during servers start in pg_upgrade*
Previous Message Robert Haas 2022-01-28 14:10:01 Re: Support escape sequence for cluster_name in postgres_fdw.application_name