Re: pgsql: Fix race leading to incorrect conflict cause in InvalidatePossib

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix race leading to incorrect conflict cause in InvalidatePossib
Date: 2024-04-11 07:08:06
Message-ID: CALj2ACVPSB74mrDTFezz-LV3Oi6F3SN71QA0oUHvndzi5dwTNg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Feb 20, 2024 at 10:14 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> Fix race leading to incorrect conflict cause in InvalidatePossiblyObsoleteSlot()

I found a typo with the code added by this commit - we've used
XLogRecPtr/InvalidXLogRecPtr for xmins in place of
TransactionId/InvalidTransactionId. Attached a patch to fix this.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v1-0001-Use-correct-datatype-for-xmin-variables-added-by-.patch application/octet-stream 1.1 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2024-04-11 07:39:01 Re: pgsql: Fix race leading to incorrect conflict cause in InvalidatePossib
Previous Message Thomas Munro 2024-04-11 02:39:02 Re: pgsql: Fix potential stack overflow in incremental backup.