Re: Cleanup - adjust the code crossing 80-column window limit

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Amul Sul <sulamul(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Cleanup - adjust the code crossing 80-column window limit
Date: 2020-07-01 10:59:34
Message-ID: CALj2ACVOAmBB9HtBdWXyTgWvzY7NchodNb8NbC1O_DY-mgvg7A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

changes look good to me.

one comment: instead of having block variables onexit, in the while
loops in shmem_exit, can we have a single local variable defined at
the start of the shmem_exit function
and reuse them in the while loops? same comment for onexit block
variable in proc_exit_prepare() function.

Patch applies successfully on commit - 4315e8c23b9a897e12fcf91de7bfd734621096bf

make check and make check-world runs are clean.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

On Wed, Jul 1, 2020 at 12:31 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>
> Hi,
>
> Attached patch makes an adjustment to ipc.c code to be in the 80-column window.
>
> Regards,
> Amul
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2020-07-01 11:06:04 Re: estimation problems for DISTINCT ON with FDW
Previous Message Dave Cramer 2020-07-01 10:43:42 Re: Binary support for pgoutput plugin