From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | postgres_fdw - make cached connection functions tests meaningful |
Date: | 2021-05-10 12:32:56 |
Message-ID: | CALj2ACVM+7TwOS+yXOdZrAmy5gWkrmQf6qwmdHrPWrVhf9Wt_w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
While working on [1], I got to know that there is a new GUC
debug_invalidate_system_caches_always that has been introduced in v14.
It can be used to switch off cache invalidation in
CLOBBER_CACHE_ALWAYS builds which makes cache sensitive tests stable.
Using this GUC, it is quite possible to make cached connection
management function tests more meaningful by returning original
values(true/false, all the output columns) instead of SELECT 1. Note
that the commit f77717b29 stabilized the tests for those functions -
postgres_fdw_disconnect, postgres_fdw_disconnect_all and
postgres_fdw_get_connections by masking actual return value of the
functions.
Attaching a patch to use the new GUC to make the functions return actual output.
Thoughts?
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
v1-0001-postgres_fdw-make-cached-connection-functions-tes.patch | application/x-patch | 16.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2021-05-10 12:39:17 | compatibility issue - problem with migrating from Postgres 11 |
Previous Message | Andrew Dunstan | 2021-05-10 12:29:40 | Re: Why do we have perl and sed versions of Gen_dummy_probes? |