| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, ikedamsh(at)oss(dot)nttdata(dot)com, tristan(at)neon(dot)tech, andres(at)anarazel(dot)de, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Support to define custom wait events for extensions |
| Date: | 2023-07-31 10:29:29 |
| Message-ID: | CALj2ACVK4KmZhNOwsRb3SYZs4hQa0mtab=9zXh=krH15uF97CA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 31, 2023 at 3:54 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Jul 31, 2023 at 05:10:21PM +0900, Kyotaro Horiguchi wrote:
> > +/*
> > + * Return the name of an wait event ID for extension.
> > + */
> > +static const char *
> > +GetWaitEventExtensionIdentifier(uint16 eventId)
> >
> > This looks inconsistent. Shouldn't it be GetWaitEventExtentionName()?
>
> This is an inspiration from GetLWLockIdentifier(), which is kind of OK
> by me. If there is a consensus in changing that, fine by me, of
> course.
+1 to GetWaitEventExtensionIdentifier for consistency with LWLock's counterpart.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-07-31 10:57:48 | Re: Avoid undefined behavior with msvc compiler (src/include/port/pg_bitutils.h) |
| Previous Message | Michael Paquier | 2023-07-31 10:24:09 | Re: Support to define custom wait events for extensions |