Re: Strengthen pg_waldump's --save-fullpage tests

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Strengthen pg_waldump's --save-fullpage tests
Date: 2023-01-12 04:46:14
Message-ID: CALj2ACVH0EE=r1GYsZO0f+n+1Ba252ujkAJZTOik8Ap_w6GdTA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 12, 2023 at 10:14 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Jan 11, 2023 at 07:17:47PM +0530, Bharath Rupireddy wrote:
> > Note that the raw page on the table might differ not just in page LSN
> > but also in other fields, for instance see heap_mask for instance. It
> > masks lsn, checksum, hint bits, unused space etc. before verifying FPI
> > consistency during recovery in
> > verifyBackupPageConsistency().
>
> FWIW, I don't really want to enter in this business here. That feels
> like a good addition of technical debt compared to the potential
> gain.

I couldn't agree more.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2023-01-12 04:47:00 Re: on placeholder entries in view rule action query's range table
Previous Message Michael Paquier 2023-01-12 04:44:05 Re: Strengthen pg_waldump's --save-fullpage tests