Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Quan Zongliang <quanzongliang(at)yeah(dot)net>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.
Date: 2021-07-10 13:39:10
Message-ID: CALj2ACV8xNg7fV6R4ApdFhJZRkVaJJNjW5WEL7UHtZKeibjSWw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 10, 2021 at 4:59 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> So I would finish with the attached, close enough to what Quan has
> sent upthread.

Thanks. The patch looks good to me, except a minor comment - isn't it
"int2 for these fields" as the fields still exist? + /* pageinspect >=
1.10 uses int4 instead of int2 for those fields */

Regards,
Bharath Rupireddy.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2021-07-10 13:49:58 Re: Reduce lock level for ALTER TABLE ... ADD CHECK .. NOT VALID
Previous Message Bharath Rupireddy 2021-07-10 13:23:50 Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW