Re: Add ORDER BY to stabilize tablespace test for partitioned index

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add ORDER BY to stabilize tablespace test for partitioned index
Date: 2021-04-09 08:15:42
Message-ID: CALj2ACUndszczXDSAOwX9w57CKNh4rVdxM8BLGqGD38zboW-UQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 9, 2021 at 1:30 PM Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> wrote:
>
> Hi, hackers!
> I noticed the Peter's commit 7e3c54168d9ec058cb3c9d47f8105b1d32dc8ceb that stabilizes certain tests by adding ORDER BY clause in tests and remember that I saw the same error in tablespaces test for creation of partitioned index. It comes very rarely and test fails on inverted order of parent and child.
>
> PFA small patch that stabilizes that test in the same style by adding ORDER BY.

+1 and the patch looks good to me.

I think we also need to add ORDER BY clauses to a few more tests(as
pointed in [1]) in create_function_3.sql which the commit 7e3c54168
missed to add. I will post the patch there in [1] and see if it gets
picked up.

[1] - https://www.postgresql.org/message-id/CALj2ACVb%2BFsKAhxAmVWSnTsPQwkvbMsxo4jGhw3uT-E036hvPA%40mail.gmail.com

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-04-09 08:39:49 Re: [HACKERS] logical decoding of two-phase transactions
Previous Message Magnus Hagander 2021-04-09 08:04:53 Re: Postgresql 13 supported on Solaris 11 O/S on SPARC hardware?