| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation |
| Date: | 2021-11-16 02:30:40 |
| Message-ID: | CALj2ACUkE=MVRJhY5ANw8WOZOLq_raQGje17_i-eQFmfMqOTpg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 16, 2021 at 3:06 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 15 Nov 2021, at 19:42, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> >
> > On 15.11.21 10:38, Bharath Rupireddy wrote:
> >>> I still think that the v8 patch posted earlier is the better option, which
> >>> increase granularity of error reporting with a small code footprint.
> >> Thanks. Attaching the v8 here again.
> >
> > I find the use of RelationUsesLocalBuffers() confusing in this patch. It would be clearer to check relpersistence directly in both branches of the if statement.
>
> Admittedly it didn't bother me, but the more I think about it the more I agree
> with Peter, so +1 on changing.
Done. PSA v9 patch.
Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-Improve-publication-error-messages.patch | application/octet-stream | 6.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-11-16 02:34:23 | Re: Printing backtrace of postgres processes |
| Previous Message | David G. Johnston | 2021-11-16 02:08:56 | Re: Add psql command to list constraints |