Re: pg_replslotdata - a tool for displaying replication slot information

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_replslotdata - a tool for displaying replication slot information
Date: 2022-01-17 10:40:13
Message-ID: CALj2ACUUaWZdBUD=1A5jX+GVQRtNmEpiw1JYuDLWYRdi264M3g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 15, 2022 at 2:20 PM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> > Bharath, perhaps you should maintain this outside of core PostgreSQL
> > for now. If some compelling use-cases ever surface that make it seem
> > worth the added maintenance burden, this thread could probably be
> > revisited.
>
> Ironically, the patch is currently failing due to translation problem:
>
> https://cirrus-ci.com/task/5467034313031680
> [19:12:28.179] su postgres -c "make -s -j${BUILD_JOBS} world-bin"
> [19:12:44.270] make[3]: *** No rule to make target 'po/cs.po', needed by 'po/cs.mo'. Stop.
> [19:12:44.270] make[2]: *** [Makefile:44: all-pg_replslotdata-recurse] Error 2
> [19:12:44.270] make[2]: *** Waiting for unfinished jobs....
> [19:12:44.499] make[1]: *** [Makefile:42: all-bin-recurse] Error 2
> [19:12:44.499] make: *** [GNUmakefile:21: world-bin-src-recurse] Error 2

Thanks Juilen. I'm okay if the patch gets dropped. But, I'm curious to
know why the above error occurred. Is it because I included the nls.mk
file in the patch which I'm not supposed to? Are these nls.mk files
generated as part of the commit that does translation changes?

Regards,
Bharath Rupireddy.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Pyhalov 2022-01-17 10:42:10 Re: Asymmetric partition-wise JOIN
Previous Message Magnus Hagander 2022-01-17 10:25:06 Re: New developer papercut - Makefile references INSTALL