From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Do we need pre-allocate WAL files during end-of-recovery checkpoint? |
Date: | 2021-12-06 12:51:40 |
Message-ID: | CALj2ACUPczrQmQBTq2MyYd24P7bVNf1+q4CkvLTmHQbkFWZyeg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
The function PreallocXlogFiles doesn't get called during
end-of-recovery checkpoint in CreateCheckPoint, see [1]. The server
becomes operational after the end-of-recovery checkpoint and may need
WAL files. However, I'm not sure how beneficial it is going to be if
the WAL is pre-allocated (as PreallocXlogFiles just allocates only 1
extra WAL file).
Thoughts?
[1]
/*
* An end-of-recovery checkpoint is really a shutdown checkpoint, just
* issued at a different time.
*/
if (flags & (CHECKPOINT_IS_SHUTDOWN | CHECKPOINT_END_OF_RECOVERY))
shutdown = true;
else
shutdown = false;
/*
* Make more log segments if needed. (Do this after recycling old log
* segments, since that may supply some of the needed files.)
*/
if (!shutdown)
PreallocXlogFiles(recptr, checkPoint.ThisTimeLineID);
Regards,
Bharath Rupireddy.
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2021-12-06 13:36:55 | Re: GUC flags |
Previous Message | Euler Taveira | 2021-12-06 12:47:41 | Re: row filtering for logical replication |