From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Should we improve "PID XXXX is not a PostgreSQL server process" warning for pg_terminate_backend(<<postmaster_pid>>)? |
Date: | 2021-03-07 10:16:39 |
Message-ID: | CALj2ACUGxedgYk-5nO8D2EJV2YHXnoycp_oqYAxDXTODhWkmkg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Feb 5, 2021 at 5:15 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> pg_terminate_backend and pg_cancel_backend with postmaster PID produce
> "PID XXXX is not a PostgresSQL server process" warning [1], which
> basically implies that the postmaster is not a PostgreSQL process at
> all. This is a bit misleading because the postmaster is the parent of
> all PostgreSQL processes. Should we improve the warning message if the
> given PID is postmasters' PID?
>
> If yes, how about a generic message for both of the functions -
> "signalling postmaster process is not allowed" or "cannot signal
> postmaster process" or some other better suggestion?
>
> [1] 2471176 ---> is postmaster PID.
> postgres=# select pg_terminate_backend(2471176);
> WARNING: PID 2471176 is not a PostgreSQL server process
> pg_terminate_backend
> ----------------------
> f
> (1 row)
> postgres=# select pg_cancel_backend(2471176);
> WARNING: PID 2471176 is not a PostgreSQL server process
> pg_cancel_backend
> -------------------
> f
> (1 row)
I'm attaching a small patch that emits a warning "signalling
postmaster with PID %d is not allowed" for postmaster and "signalling
PostgreSQL server process with PID %d is not allowed" for auxiliary
processes such as checkpointer, background writer, walwriter.
However, for stats collector and sys logger processes, we still get
"PID XXXXX is not a PostgreSQL server process" warning because they
don't have PGPROC entries(??). So BackendPidGetProc and
AuxiliaryPidGetProc will not help and even pg_stat_activity is not
having these processes' pid.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
v1-0001-Improve-PID-XXXX-is-not-a-PostgreSQL-server-proce.patch | application/octet-stream | 2.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2021-03-07 10:24:02 | Re: [patch] bit XOR aggregate functions |
Previous Message | Vik Fearing | 2021-03-07 10:13:42 | Re: [patch] bit XOR aggregate functions |