Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Tue, Oct 19, 2021 at 11:49 AM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Tue, Oct 19, 2021 at 6:16 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >
> > On Mon, Oct 18, 2021 at 09:56:41AM -0400, Andrew Dunstan wrote:
> > > Well, see
> > > <https://www.postgresql.org/docs/current/install-windows-full.html#id-1.6.5.8.12>
> > >
> > > Maybe we should move that section.
> >
> > As this is the part of the docs where we document the builds, it
> > looks indeed a bit confusing to have all the requirements for the
> > TAP tests there. The section "Regression Tests" cannot be used for
> > the case of VS, and the section for TAP is independent of that so we
> > could use platform-dependent sub-sections.
> >
> > Could it be better to move all the contents of "Running the Regression
> > Tests" from the Windows installation page to the section of
> > "Regression Tests" instead? That would mean spreading the knowledge
> > of vcregress.pl to more than one place, though.
>
> IMO, it is better to add a note in the "Running the Tests" section at
> [1] and a link to the windows specific section at [2]. This will keep
> all the windows specific things at one place without any duplication
> of vcregress.pl knowledge. Thoughts? If okay, I will send a patch.
>
> [1] https://www.postgresql.org/docs/devel/regress-run.html
> [2] https://www.postgresql.org/docs/devel/install-windows-full.html#id-1.6.5.8.12

Here's the documentation v1 patch that I've come up with. Please review it.

Regards,
Bharath Rupireddy.