| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Zhihong Yu <zyu(at)yugabyte(dot)com>, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |
| Date: | 2021-01-14 11:36:07 |
| Message-ID: | CALj2ACU6Q4wicO4B9kc65zxu-Jb7QbFYTpTK9YUqv1sqgsfn2A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 14, 2021 at 3:52 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> - if (!HeapTupleIsValid(tup))
> - elog(ERROR, "cache lookup failed for user mapping %u", entry->key);
> - umform = (Form_pg_user_mapping) GETSTRUCT(tup);
> - server = GetForeignServer(umform->umserver);
> - ReleaseSysCache(tup);
> + server = GetForeignServer(entry->serverid);
>
> What about applying only the change about serverid, as a separate patch at
> first? This change itself is helpful to get rid of error "cache lookup failed"
> in pgfdw_reject_incomplete_xact_state_change(). Patch attached.
Right, we can get rid of the "cache lookup failed for user mapping"
error and also storing server oid in the cache entry is helpful for
the new functions we are going to introduce.
serverid_v1.patch looks good to me. Both make check and make
check-world passes on my system.
I will respond to other comments soon.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Li Japin | 2021-01-14 12:06:01 | Re: Logical Replication - behavior of ALTER PUBLICATION .. DROP TABLE and ALTER SUBSCRIPTION .. REFRESH PUBLICATION |
| Previous Message | Amul Sul | 2021-01-14 11:29:14 | Re: [Patch] ALTER SYSTEM READ ONLY |