| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | bt21masumurak <bt21masumurak(at)oss(dot)nttdata(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improve the HINT message of the ALTER command for postgres_fdw |
| Date: | 2021-10-25 12:27:27 |
| Message-ID: | CALj2ACU4FNWJ694AHXay3AG+xawRqd9q8w+bw9BR+CUNiOatFg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 25, 2021 at 4:36 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> On 2021/10/25 16:44, Bharath Rupireddy wrote:
> > Yeah, let's focus on fixing the hint message here and the
> > alter_foreign_data_wrapper_options_v3.patch LGTM.
>
> Thanks! But since v3 changed the error codes, I got rid of those
> changes and made v4 patch. Attached.
That's okay as we plan to deal with the error code stuff separately.
> > Why didn't we have a test case for file_fdw? It looks like the
> > file_fdw contrib module doesn't have any test cases in its sql
> > directory. I'm not sure if the module code is being covered in
> > someother tests.
>
> You can see the regression test for file_fdw,
> in contrib/file_fdw/input and output directories.
I missed it. Thanks. I see that there are already test cases covering
error message with hint - "There are no valid options in this
context."
The v4 patch LGTM.
Regards,
Bharath Rupireddy.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2021-10-25 12:29:24 | Re: pg_dump versus ancient server versions |
| Previous Message | Hans Buschmann | 2021-10-25 12:23:59 | AW: Assorted improvements in pg_dump |