Re: Inconsistency between table am callback and table function names

From: Ashwin Agrawal <aagrawal(at)pivotal(dot)io>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Inconsistency between table am callback and table function names
Date: 2019-05-24 16:40:46
Message-ID: CALfoeitycYHAVsB=ji-9xSyfoS_zf6tPC5EG=T-dystpqcdG_g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 23, 2019 at 4:32 PM Andres Freund <andres(at)anarazel(dot)de> wrote:

> Hi,
>
> On 2019-05-14 12:11:46 -0700, Ashwin Agrawal wrote:
> > Thank you. Please find the patch to rename the agreed functions. It would
> > be good to make all consistent instead of applying exception to three
> > functions but seems no consensus on it. Given table_ api are new, we
> could
> > modify them leaving systable_ ones as is, but as objections left that as
> is.
>
> I've pushed a slightly modified version (rebase, some additional
> newlines due to the longer function names) now. Thanks for the patch!
>

Thanks a lot Andres. With pg_intend run before the patch on master, I can
imagine possibly generated additional work for you on this.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2019-05-24 16:54:46 Re: Excessive memory usage in multi-statement queries w/ partitioning
Previous Message Konstantin Knizhnik 2019-05-24 16:37:15 Re: Read-only access to temp tables for 2PC transactions