| From: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Removing a few more lseek() calls |
| Date: | 2019-06-06 17:16:04 |
| Message-ID: | CALfoeitasTM935rd4Jy0HhFJXW3eLM7YYKjr8WkpH5A-JGwh+w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 30, 2019 at 2:14 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> Hello,
>
> Patch 0001 gets rid of the unconditional lseek() calls for SLRU I/O,
> as a small follow-up to commit c24dcd0c. Patch 0002 gets rid of a few
> places that usually do a good job of avoiding lseek() calls while
> reading and writing WAL, but it seems better to have no code at all.
>
I reviewed the changes and they look good to me. Code looks much cleaner
after 2nd patch.
After these changes, only one usage of SLRU_SEEK_FAILED remains in
SimpleLruDoesPhysicalPageExist().
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-06-06 17:18:50 | Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.) |
| Previous Message | Tom Lane | 2019-06-06 16:51:30 | Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.) |