Re: Inconsistency between table am callback and table function names

From: Ashwin Agrawal <aagrawal(at)pivotal(dot)io>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Inconsistency between table am callback and table function names
Date: 2019-05-10 17:43:44
Message-ID: CALfoeis1efGPnMn_eiVuiDk-_O0dgTV-6nnEbJL0tZ7mjL=kAQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 9, 2019 at 8:52 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> The changes necessary for tableam were already huge. Changing naming
> schemes for functions that are used all over the backend (e.g. ~80 calls
> to table_beginscan), and where there's other wrapper functions that also
> widely used (237 calls to systable_beginscan) which didn't have to be
> touched, at the same time would have made it even harder to review.

If there are no objections to renaming now, as separate independent
patch, I am happy to do the same and send it across. Will rename to
make it consistent as mentioned at start of the thread leaving
table_relation_xxx() ones as is today.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-05-10 17:51:41 Re: Inconsistency between table am callback and table function names
Previous Message Julien Rouhaud 2019-05-10 15:58:03 Re: Bug in reindexdb's error reporting