Re: [PATCH] Fix Potential Memory Leak in pg_amcheck Code

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Saladin <312199339(at)qq(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Fix Potential Memory Leak in pg_amcheck Code
Date: 2025-02-23 06:49:05
Message-ID: CALdSSPjvPr7QNNwPB4i=sF6eaZO=j53m+aj+WqHPi0rUbJd9Ew@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

On Fri, 7 Feb 2025 at 13:28, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> That being said, there is
> value in doing the right thing and setting good examples in our own code as
> many do read it and reference it.

> We call PQclear on such a
> case elsewhere in the file so it's not entirely consistent, but it's not all
> that important as the memory will be reclaimed at exit.

So, are we +1 or -1 on moving this forward?

--
Best regards,
Kirill Reshke

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2025-02-23 08:35:49 Re: generic plans and "initial" pruning
Previous Message Peter Smith 2025-02-23 03:19:12 Re: Proposal: Filter irrelevant change before reassemble transactions during logical decoding