From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | TerminateOtherDBBackends code comments inconsistency. |
Date: | 2024-04-11 13:27:47 |
Message-ID: | CALdSSPjrLvua14C9ckAYbY5aQXepA56d9gd=1Pv85SmtsPvkjA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi hackers!
While working on [0] i have noticed this comment in
TerminateOtherDBBackends function:
/*
* Check whether we have the necessary rights to terminate other
* sessions. We don't terminate any session until we ensure that we
* have rights on all the sessions to be terminated. These checks are
* the same as we do in pg_terminate_backend.
*
* In this case we don't raise some warnings - like "PID %d is not a
* PostgreSQL server process", because for us already finished session
* is not a problem.
*/
This statement is not true after 3a9b18b.
"These checks are the same as we do in pg_terminate_backend."
But the code is still correct, I assume... or not? In fact, we are
killing autovacuum workers which are working with a given database
(proc->roleId == 0), which is OK in that case. Are there any other
cases when proc->roleId == 0 but we should not be able to kill such a
process?
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2024-04-11 13:29:58 | Re: Typos in the code and README |
Previous Message | Dmitry Koval | 2024-04-11 13:27:40 | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |